Make transaction a required argument of Span#1921
Merged
Conversation
According to the specification, a Span must has a Transaction, whether it's directly assigned to it or inherited from its parent Span. So this commit enforces that by requiring the `transaction:` argument on Span's constructor. Although it makes test setup a bit more complicated, it does make tests reflect our real-world expectation more accurately.
9af3670 to
78bf9e7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1921 +/- ##
==========================================
- Coverage 98.43% 98.42% -0.01%
==========================================
Files 151 151
Lines 9273 9283 +10
==========================================
+ Hits 9128 9137 +9
- Misses 145 146 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sl0thentr0py
approved these changes
Oct 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the specification, a Span must has a Transaction, whether it's directly assigned to it or inherited from its parent Span.
So this commit enforces that by requiring the
transaction:argument on Span's constructor.Although it makes test setup a bit more complicated, it does make tests reflect our real-world expectation more accurately.
Although this PR changes the constructor of the
SpanandTransactionclasses, they were never designed to be initialized directly by users. So this is not considered a breaking changeCloses #1890