Skip to content

Baggage creation for head SDK#1898

Merged
sl0thentr0py merged 5 commits intoneel/baggage-dsc-continuationfrom
neel/baggage-dsc-head
Sep 27, 2022
Merged

Baggage creation for head SDK#1898
sl0thentr0py merged 5 commits intoneel/baggage-dsc-continuationfrom
neel/baggage-dsc-head

Conversation

@sl0thentr0py
Copy link
Copy Markdown
Member

@sl0thentr0py sl0thentr0py commented Sep 15, 2022

Creates new Baggage entries when the ruby SDK is the head SDK, i.e the first SDK that originates a distributed trace.
The new Baggage entry is created when get_baggage is first called, either

  • when the first outgoing HTTP request is made
  • the first transaction finishes and the envelope is sent to sentry

closes #1836

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 15, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.41%. Comparing base (dde8094) to head (897c5e7).

Additional details and impacted files
@@                        Coverage Diff                        @@
##           neel/baggage-dsc-continuation    #1898      +/-   ##
=================================================================
- Coverage                          98.42%   98.41%   -0.01%     
=================================================================
  Files                                150      150              
  Lines                               9096     9177      +81     
=================================================================
+ Hits                                8953     9032      +79     
- Misses                               143      145       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sl0thentr0py sl0thentr0py marked this pull request as ready for review September 19, 2022 10:58
@sl0thentr0py sl0thentr0py requested a review from st0012 September 19, 2022 10:58
@sl0thentr0py sl0thentr0py force-pushed the neel/baggage-dsc-continuation branch from 7490335 to 8b8af16 Compare September 19, 2022 12:08
@sl0thentr0py sl0thentr0py force-pushed the neel/baggage-dsc-head branch 2 times, most recently from a605ce7 to c9764dd Compare September 19, 2022 12:36
@st0012 st0012 added this to the 5.5.0 milestone Sep 19, 2022
@sl0thentr0py sl0thentr0py merged commit 8fae12f into neel/baggage-dsc-continuation Sep 27, 2022
@sl0thentr0py sl0thentr0py deleted the neel/baggage-dsc-head branch September 27, 2022 09:47
@sl0thentr0py sl0thentr0py modified the milestones: 5.5.0, Dynamic Sampling Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants