Conversation
* fix rack lint spec since uppercase no longer allowed in response headers * expand CI matrix to test on rack 2 & 3
c11dc8e to
269f7f9
Compare
Codecov ReportBase: 98.42% // Head: 98.40% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1884 +/- ##
==========================================
- Coverage 98.42% 98.40% -0.03%
==========================================
Files 148 148
Lines 8884 8886 +2
==========================================
Hits 8744 8744
- Misses 140 142 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
ughh now sqlite is failing 😭 |
3a835df to
4304412
Compare
|
@st0012 also one more thing I noticed, we have |
|
@sl0thentr0py I suspect it may be related to Ruby 2.4 support? We can try removing that config though. |
77dc8d5 to
e4f24e8
Compare
77b1109 to
93cd32f
Compare
st0012
left a comment
There was a problem hiding this comment.
All look good, just have a small comment. Great job 🙌
| # NOTE: This will be removed in version 3.0+ | ||
| def is_server_protocol?(key, value, protocol_version) | ||
| rack_version = Gem::Version.new(::Rack.release) | ||
| return false if rack_version >= Gem::Version.new("3.0") |
There was a problem hiding this comment.
@sl0thentr0py consider we have this change, it probably still needs a changelog entry.
|
@st0012 can you approve if ok? (we added a required check for approval now for compliance reasons, so need it to merge) |
is_server_protocol?check for rack 3 supportbundler: 1pin in actionssqlite3 1.5.0 has pre-built binaries from ruby 2.6 onwards so useforce_ruby_platformfor 2.4 and 2.5 fordelayed_job