Capture Rails runner's exceptions before exiting#1820
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1820 +/- ##
=======================================
Coverage 98.46% 98.46%
=======================================
Files 145 145
Lines 8659 8661 +2
=======================================
+ Hits 8526 8528 +2
Misses 133 133 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sl0thentr0py
approved these changes
May 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rails currently doesn't provide any callback for capturing Rails runner's exceptions, so we need to use
at_exitfor it. But it should be supported in 7.1 (PR: rails/rails#44999) via the enhanced error reporter integration.And because it's very complicated, if not impossible, to monitor if a Rails runner process reports to Sentry, so I didn't add any test for it. I used this for testing instead:
Implements and closes #1789