Skip to content

Sentry.with_child_span should check SDK's initialization state#1819

Merged
st0012 merged 2 commits intomasterfrom
fix-#1818
May 14, 2022
Merged

Sentry.with_child_span should check SDK's initialization state#1819
st0012 merged 2 commits intomasterfrom
fix-#1818

Conversation

@st0012
Copy link
Copy Markdown
Contributor

@st0012 st0012 commented May 14, 2022

Fixes #1818

@st0012 st0012 added this to the 5.3.1 milestone May 14, 2022
@st0012 st0012 self-assigned this May 14, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 14, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.45%. Comparing base (0fe8d27) to head (bc9dea5).
Report is 535 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1819      +/-   ##
==========================================
+ Coverage   98.43%   98.45%   +0.01%     
==========================================
  Files         145      145              
  Lines        8587     8589       +2     
==========================================
+ Hits         8453     8456       +3     
+ Misses        134      133       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@st0012 st0012 merged commit 8bd4054 into master May 14, 2022
@st0012 st0012 deleted the fix-#1818 branch May 14, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sentry.with_child_span didn't handle current scope is nil

2 participants