Don't require a DB connection, but release one if it is acquired#1812
Merged
st0012 merged 1 commit intogetsentry:masterfrom May 7, 2022
jakeonfire:master
Merged
Don't require a DB connection, but release one if it is acquired#1812st0012 merged 1 commit intogetsentry:masterfrom jakeonfire:master
st0012 merged 1 commit intogetsentry:masterfrom
jakeonfire:master
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1812 +/- ##
==========================================
- Coverage 98.45% 98.45% -0.01%
==========================================
Files 145 145
Lines 8589 8587 -2
==========================================
- Hits 8456 8454 -2
Misses 133 133 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
st0012
approved these changes
May 7, 2022
Contributor
st0012
left a comment
There was a problem hiding this comment.
Just checked that #with_connection uses #release_connection underneath, so calling it directly is even better. Thanks for the fix 👍
This was referenced May 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solves #1808 which evolved from #1320. tip from https://stackoverflow.com/a/26733385.