Don't mask real error when converting an event to JSON fails#1797
Closed
drcapulet wants to merge 1 commit intogetsentry:masterfrom
Closed
Don't mask real error when converting an event to JSON fails#1797drcapulet wants to merge 1 commit intogetsentry:masterfrom
drcapulet wants to merge 1 commit intogetsentry:masterfrom
Conversation
559ec5b to
419e56b
Compare
Contributor
|
It looks like such error only happens at the line of If that's the case, perhaps we should rescue that method call to make the case explicit? Something like: begin
event_hash = event.to_json_compatible
rescue => e
log_error("Converting #{event.inspect} to JSON compatible hash failed", e, debug: configuration.debug)
end |
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Contributor
|
@drcapulet Do you want to continue on this one? Or you're ok with me opening another PR to finish it? |
Contributor
|
Closing in favor of #1853 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the event is unable to be converted to JSON, trying to key into
event_hasherrors because it isnil. I'm going to look into how to prevent that issue in a later PR.