Skip to content

Add request env to rails middleware#1792

Merged
st0012 merged 2 commits intogetsentry:masterfrom
linhmtran168:add_request_env_to_sampling_context
Apr 17, 2022
Merged

Add request env to rails middleware#1792
st0012 merged 2 commits intogetsentry:masterfrom
linhmtran168:add_request_env_to_sampling_context

Conversation

@linhmtran168
Copy link
Copy Markdown
Contributor

Description

@st0012 st0012 added this to the 5.3.0 milestone Apr 13, 2022
@st0012
Copy link
Copy Markdown
Contributor

st0012 commented Apr 13, 2022

@linhmtran168 Thanks for catching this. I actually consider it a bug fix instead of a feature 🙂 Would you mind also adding a changelog entry? Thx

@linhmtran168
Copy link
Copy Markdown
Contributor Author

@st0012 I added the changelog entry 😄

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 17, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.41%. Comparing base (9f6ab0c) to head (403860f).
Report is 550 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1792      +/-   ##
==========================================
- Coverage   98.42%   98.41%   -0.01%     
==========================================
  Files         145      145              
  Lines        8559     8576      +17     
==========================================
+ Hits         8424     8440      +16     
- Misses        135      136       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@st0012
Copy link
Copy Markdown
Contributor

st0012 commented Apr 17, 2022

@linhmtran168 Thank you 👍

@st0012 st0012 merged commit 942f645 into getsentry:master Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add request info to custom_sampling_context in Rails middleware

3 participants