Allow config.transport.proxy to be a String or URI#1788
Merged
st0012 merged 1 commit intogetsentry:masterfrom Apr 8, 2022
Merged
Allow config.transport.proxy to be a String or URI#1788st0012 merged 1 commit intogetsentry:masterfrom
st0012 merged 1 commit intogetsentry:masterfrom
Conversation
24ad414 to
43c1455
Compare
Contributor
Author
|
I added a simplified version for Faraday's proxy normalization. I'm not sure there is much additional value in going deeper here, but I can update if necessary. |
Fixes getsentry#1782 Update `config.transport.proxy` to allow String and URI values as previously supported by `sentry-ruby` versions <= 4.8 using Faraday.
43c1455 to
c6131a8
Compare
Contributor
Author
|
Thanks @st0012! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1782
Update
config.transport.proxyto allow String and URI values aspreviously supported by
sentry-rubyversions <= 4.8 using Faraday.