Skip to content

Fix sentry-rails's tracing spans not nesting issue#1784

Merged
st0012 merged 5 commits intomasterfrom
fix-#1723
Apr 9, 2022
Merged

Fix sentry-rails's tracing spans not nesting issue#1784
st0012 merged 5 commits intomasterfrom
fix-#1723

Conversation

@st0012
Copy link
Copy Markdown
Contributor

@st0012 st0012 commented Apr 4, 2022

Fixes #1723

Before

截圖 2022-04-04 21 19 01

After

截圖 2022-04-04 21 19 15

@st0012 st0012 added this to the 5.3.0 milestone Apr 4, 2022
@st0012 st0012 self-assigned this Apr 4, 2022
@st0012 st0012 changed the title Fixes sentry-rails's tracing spans not nesting issue Fix sentry-rails's tracing spans not nesting issue Apr 4, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 4, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.41%. Comparing base (72396ce) to head (42308ad).
⚠️ Report is 574 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1784      +/-   ##
==========================================
- Coverage   98.41%   98.41%   -0.01%     
==========================================
  Files         145      145              
  Lines        8562     8559       -3     
==========================================
- Hits         8426     8423       -3     
  Misses        136      136              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@st0012 st0012 force-pushed the add-sentry-with-child-span branch from 0807404 to 4af72c0 Compare April 8, 2022 08:28
Base automatically changed from add-sentry-with-child-span to master April 8, 2022 08:36
@st0012 st0012 merged commit c735744 into master Apr 9, 2022
@st0012 st0012 deleted the fix-#1723 branch April 9, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants