Skip to content

Add request env to sampling context#1749

Merged
st0012 merged 2 commits intomasterfrom
fix-#1732
Mar 3, 2022
Merged

Add request env to sampling context#1749
st0012 merged 2 commits intomasterfrom
fix-#1732

Conversation

@st0012
Copy link
Copy Markdown
Contributor

@st0012 st0012 commented Feb 27, 2022

Closes #1732

@st0012 st0012 added this to the 5.2.0 milestone Feb 27, 2022
@st0012 st0012 self-assigned this Feb 27, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 27, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.41%. Comparing base (abb3ced) to head (75f0ea6).
⚠️ Report is 598 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1749   +/-   ##
=======================================
  Coverage   98.40%   98.41%           
=======================================
  Files         141      141           
  Lines        8047     8053    +6     
=======================================
+ Hits         7919     7925    +6     
  Misses        128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@st0012
Copy link
Copy Markdown
Contributor Author

st0012 commented Feb 27, 2022

@sl0thentr0py I think having the entire request env can enable the most flexible sampling logic? Since the sampling context should be tossed away right after the sampling is done, I don't see any obvious issue for it. Do you have any concern on this?

@sl0thentr0py
Copy link
Copy Markdown
Member

@st0012 yeah that's perfect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add request info to custom_sampling_context in rack middleware

3 participants