Conversation
Contributor
Author
|
@sl0thentr0py I know the code could still be refactored (which I'll do later), but can you give it a quick scan and see if the approach looks good? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1747 +/- ##
==========================================
+ Coverage 98.43% 98.46% +0.03%
==========================================
Files 144 144
Lines 8312 8412 +100
==========================================
+ Hits 8182 8283 +101
+ Misses 130 129 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sl0thentr0py
approved these changes
Mar 7, 2022
Because we now need to check if a serialized envelope item is oversized (see #1603 (comment)), envelope serialization is better performed by Transport to have more control to filter oversized items.
Transport#serialize_envelope to control envelope serialization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because we now need to check if a serialized envelope item is oversized (see #1603 (comment)), envelope serialization is better performed by Transport to have more control to filter oversized items.