Skip to content

Encapsulate extension helpers#1725

Merged
st0012 merged 2 commits intomasterfrom
encapsulate-extensions
Feb 17, 2022
Merged

Encapsulate extension helpers#1725
st0012 merged 2 commits intomasterfrom
encapsulate-extensions

Conversation

@st0012
Copy link
Copy Markdown
Contributor

@st0012 st0012 commented Feb 12, 2022

As mentioned in #1708, some extensions from the SDK expose internal methods publicly. From what I can tell this includes sentry-rails's ActiveJob integration and sentry-resque. This fixes the issue.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 12, 2022

Codecov Report

❌ Patch coverage is 98.36066% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 98.41%. Comparing base (623d046) to head (90e9f1f).
⚠️ Report is 598 commits behind head on master.

Files with missing lines Patch % Lines
sentry-resque/lib/sentry/resque.rb 96.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1725      +/-   ##
==========================================
+ Coverage   98.40%   98.41%   +0.01%     
==========================================
  Files         141      141              
  Lines        8012     8019       +7     
==========================================
+ Hits         7884     7892       +8     
+ Misses        128      127       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@st0012 st0012 force-pushed the encapsulate-extensions branch from 3ee4e00 to 90e9f1f Compare February 12, 2022 16:33
@lewispb
Copy link
Copy Markdown
Contributor

lewispb commented Feb 13, 2022

LGTM!

@st0012 st0012 requested a review from sl0thentr0py February 16, 2022 21:21
@st0012 st0012 merged commit 7197bd0 into master Feb 17, 2022
@st0012 st0012 deleted the encapsulate-extensions branch February 17, 2022 18:06
@st0012 st0012 modified the milestones: 5.2.0, 5.1.1 Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants