Fix context merging #1722#1724
Merged
st0012 merged 2 commits intogetsentry:masterfrom Feb 11, 2022
thomasjachmann:fix-context-merging
Merged
Fix context merging #1722#1724st0012 merged 2 commits intogetsentry:masterfrom thomasjachmann:fix-context-merging
st0012 merged 2 commits intogetsentry:masterfrom
thomasjachmann:fix-context-merging
Conversation
When using the same key in a context hash, the new value should overwrite the old value. Before, the value having been set first would always win. fixes #1722
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1724 +/- ##
==========================================
- Coverage 98.41% 98.38% -0.03%
==========================================
Files 141 141
Lines 8004 8012 +8
==========================================
+ Hits 7877 7883 +6
- Misses 127 129 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
st0012
approved these changes
Feb 11, 2022
Contributor
st0012
left a comment
There was a problem hiding this comment.
Yes, that's a bug. Thank you for reporting it and making the PR! 😄
|
Thank for you fixing! Curious, is there a timeline by which this goes live in new release? |
Contributor
|
This should go out with version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the same key in a context hash, the new value should
overwrite the old value. Before, the value having been set first would
always win.
fixes #1722