Skip to content

Transaction#finish should ignore the parent's sampling decision#1716

Merged
st0012 merged 2 commits intomasterfrom
fix-#1712
Feb 10, 2022
Merged

Transaction#finish should ignore the parent's sampling decision#1716
st0012 merged 2 commits intomasterfrom
fix-#1712

Conversation

@st0012
Copy link
Copy Markdown
Contributor

@st0012 st0012 commented Feb 10, 2022

Fixes #1712

@st0012 st0012 added this to the 5.1.0 milestone Feb 10, 2022
@st0012 st0012 self-assigned this Feb 10, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 10, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.42%. Comparing base (ee5eadc) to head (db5ecbe).
⚠️ Report is 606 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1716      +/-   ##
==========================================
+ Coverage   98.41%   98.42%   +0.01%     
==========================================
  Files         140      140              
  Lines        7990     7994       +4     
==========================================
+ Hits         7863     7868       +5     
+ Misses        127      126       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@st0012 st0012 requested a review from sl0thentr0py February 10, 2022 14:53
@st0012 st0012 merged commit aeb38cf into master Feb 10, 2022
@st0012 st0012 deleted the fix-#1712 branch February 10, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logs are misleading when transaction is sampled due to parent being sampled

3 participants