Merged
Conversation
Since RequestInterface is where the env mutation happens, adding dup call there makes the whole flow easier to understand and avoids future misuse of the APIs (e.g. manually initializes the RequestInterface without first duplicating the env).
Contributor
Author
|
@sl0thentr0py need to merge this for other work. but feel free to add comments and I'll address them in other PRs. |
Member
|
lgtm :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the 2 class methods that I think are redundant:
.buildand.clean_env, as they can just happen inRequestInterface#initialize.I also don't think this is a breaking change as
Event#rack_env=should be the API for users to attaching request data to an event.