Explicitly passing Rack related configurations#1662
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1662 +/- ##
=======================================
Coverage 98.47% 98.47%
=======================================
Files 136 136
Lines 7655 7656 +1
=======================================
+ Hits 7538 7539 +1
Misses 117 117
Continue to review full report at Codecov.
|
st0012
commented
Jan 2, 2022
sl0thentr0py
approved these changes
Jan 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
RequestInterfaceis directly initialized fromEvent, it's entirely possible to pass everything it needs with method calls.This change will make
RequestInterface's dependencies clearer and shouldn't break any user program (interfaces shouldn't be initialized manually).