Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1624 +/- ##
==========================================
- Coverage 98.50% 98.49% -0.02%
==========================================
Files 133 133
Lines 7382 7394 +12
==========================================
+ Hits 7272 7283 +11
- Misses 110 111 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sl0thentr0py
requested changes
Nov 22, 2021
sl0thentr0py
approved these changes
Nov 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I assumed the block passed to
BackgroundWorker#performshould already handle exceptions (e.g.Client#send_event). But #1618 showed it's not entirely true. So this PR adds exception logging to background worker and provide a safer approach to monkey patch its method.Closes #1618