Skip to content

Merge context with the same key instead of replacing the old value.#1621

Merged
st0012 merged 3 commits intomasterfrom
fix-#1619
Nov 19, 2021
Merged

Merge context with the same key instead of replacing the old value.#1621
st0012 merged 3 commits intomasterfrom
fix-#1619

Conversation

@st0012
Copy link
Copy Markdown
Contributor

@st0012 st0012 commented Nov 19, 2021 •
edited
Loading

Before:

Sentry.set_context(:character, { name: "John" })
Sentry.set_context(:character, { age: 25 })
p Sentry.get_current_scope.contexts[:character] #=> {:age=>25}

After:

Sentry.set_context(:character, { name: "John" })
Sentry.set_context(:character, { age: 25 })
p Sentry.get_current_scope.contexts[:character] #=> {:age=>25, :name=>"John"}

Closes #1619

@st0012 st0012 added this to the 4.8.1 milestone Nov 19, 2021
@st0012 st0012 self-assigned this Nov 19, 2021
@st0012 st0012 mentioned this pull request Nov 19, 2021
Closed
@st0012 st0012 requested a review from sl0thentr0py November 19, 2021 12:28
@st0012 st0012 merged commit 23c66f5 into master Nov 19, 2021
@st0012 st0012 deleted the fix-#1619 branch November 19, 2021 15:47
@tsu-shiuan tsu-shiuan mentioned this pull request May 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

Assignees

@st0012 st0012

Labels

sentry-ruby

Projects

None yet

Milestone

4.8.1

Development

Successfully merging this pull request may close these issues.

Should set_context with the same context name clobber existing values?

2 participants

@st0012 @sl0thentr0py