Skip to content

Move Sentry::Rails::CaptureExceptions before ActionDispatch::ShowExceptions#1608

Merged
st0012 merged 2 commits intomasterfrom
simplify-sentry-rails-exception-handling-chain
Nov 7, 2021
Merged

Move Sentry::Rails::CaptureExceptions before ActionDispatch::ShowExceptions#1608
st0012 merged 2 commits intomasterfrom
simplify-sentry-rails-exception-handling-chain

Conversation

@st0012
Copy link
Copy Markdown
Contributor

@st0012 st0012 commented Nov 6, 2021

This can save us from reporting the exception manually in RescuedExceptionInterceptor, which was designed to prevent the exception being rescued by ShowExceptions.

This can save us from reporting the exception manually in
RescuedExceptionInterceptor, which was designed to prevent the exception
being rescued by ShowExceptions.
@st0012 st0012 added this to the 4.8.0 milestone Nov 6, 2021
@st0012 st0012 self-assigned this Nov 6, 2021
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 6, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.43%. Comparing base (81c0f81) to head (032e995).
⚠️ Report is 841 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1608      +/-   ##
==========================================
- Coverage   98.45%   98.43%   -0.02%     
==========================================
  Files         130      130              
  Lines        7230     7221       -9     
==========================================
- Hits         7118     7108      -10     
- Misses        112      113       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@st0012 st0012 merged commit 7a3a86b into master Nov 7, 2021
@st0012 st0012 deleted the simplify-sentry-rails-exception-handling-chain branch November 7, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants