[ENHANCE] Support Sidekiq Tags in Sentry#1596
Merged
st0012 merged 1 commit intogetsentry:masterfrom Nov 5, 2021
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1596 +/- ##
==========================================
+ Coverage 98.44% 98.46% +0.01%
==========================================
Files 129 130 +1
Lines 7218 7230 +12
==========================================
+ Hits 7106 7119 +13
+ Misses 112 111 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@berniechiu thanks for the PR 🎉 I'll take a look this week 🙂 |
st0012
reviewed
Oct 28, 2021
sentry-sidekiq/spec/sentry/sidekiq/sentry_context_middleware_spec.rb
Outdated
Show resolved
Hide resolved
7e6a287 to
f13f198
Compare
st0012
approved these changes
Nov 5, 2021
Contributor
st0012
left a comment
There was a problem hiding this comment.
@berniechiu thanks for the great work 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1488
Description
Add Sidekiq Tags to Sentry
Notes
Just Few things TBC
sidekiq.#{name}here, the reason for prefixing withsidekiqis that tag naming sometimes can be too generic, might conflict with custom setup from users. But can also be other naming, welcome for any feedback