Enable local variable capture TracePoint when SDK inits#1589
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1589 +/- ##
==========================================
- Coverage 98.42% 98.41% -0.01%
==========================================
Files 129 129
Lines 7218 7245 +27
==========================================
+ Hits 7104 7130 +26
- Misses 114 115 +1
Continue to review full report at Codecov.
|
16c2145 to
44f7814
Compare
44f7814 to
a793b4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1580, only exceptions happen in requests would have its local variables captured for testing purpose. And after more than a week of testing in a real-world Rails app, I didn't see any issue or regression. So this PR enabled the TracePoint globally to make it include exceptions outside of a request (e.g. background jobs).