Skip to content

Avoid injecting tracing timestamp to all ActiveSupport instrument events#1576

Merged
st0012 merged 4 commits intomasterfrom
fix-#1573
Sep 19, 2021
Merged

Avoid injecting tracing timestamp to all ActiveSupport instrument events#1576
st0012 merged 4 commits intomasterfrom
fix-#1573

Conversation

@st0012
Copy link
Copy Markdown
Contributor

@st0012 st0012 commented Sep 18, 2021

Fixes #1573

@st0012 st0012 added this to the 4.8.0 milestone Sep 18, 2021
@st0012 st0012 self-assigned this Sep 18, 2021
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 18, 2021

Codecov Report

❌ Patch coverage is 95.31250% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.55%. Comparing base (a6ce224) to head (7348bc6).
⚠️ Report is 739 commits behind head on master.

Files with missing lines Patch % Lines
...readcrumbs/monotonic_active_support_logger_spec.rb 91.78% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1576      +/-   ##
==========================================
+ Coverage   98.06%   98.55%   +0.49%     
==========================================
  Files         126      127       +1     
  Lines        6932     7001      +69     
==========================================
+ Hits         6798     6900     +102     
+ Misses        134      101      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@st0012 st0012 merged commit 65a51e0 into master Sep 19, 2021
@st0012 st0012 deleted the fix-#1573 branch September 19, 2021 06:34
@st0012 st0012 modified the milestones: 4.8.0, 4.7.3 Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

can't write unknown attribute start_timestamp during instrumentation

2 participants