Conversation
Currently, exceptions raised by middlewares placed between RescuedExceptionInterceptor and DebugExceptions are rescued DebugExceptions without anyway to be reported to the CaptureExceptions middleware. By placing RescuedExceptionInterceptor closer to DebugExceptions, it should avoid similar issues.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1564 +/- ##
==========================================
+ Coverage 97.92% 98.29% +0.37%
==========================================
Files 222 127 -95
Lines 10870 7034 -3836
==========================================
- Hits 10644 6914 -3730
+ Misses 226 120 -106 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, exceptions raised by middlewares placed between RescuedExceptionInterceptor and DebugExceptions are rescued DebugExceptions without anyway to be reported to the CaptureExceptions middleware.
By placing RescuedExceptionInterceptor closer to DebugExceptions, it should avoid similar issues.
Closes #1563