Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1555 +/- ##
==========================================
+ Coverage 97.92% 98.29% +0.37%
==========================================
Files 222 127 -95
Lines 10867 7030 -3837
==========================================
- Hits 10641 6910 -3731
+ Misses 226 120 -106 Continue to review full report at Codecov.
|
7c1ca91 to
faba24d
Compare
rhcarvalho
approved these changes
Sep 1, 2021
Contributor
rhcarvalho
left a comment
There was a problem hiding this comment.
Thanks @st0012 !
Most other SDKs call this file LICENSE (without extension), if it makes no difference otherwise I'd rename the file to match the other SDKs.
GitHub can't capture the license information from a symlink.
faba24d to
19e7e4f
Compare
Contributor
Author
|
@rhcarvalho 👍 updated. merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub can't capture the repo's license from a link file. So I think we need to give it a copy of the actual license.