Skip to content

Don't start Sentry::SendEventJob's transaction#1547

Merged
st0012 merged 2 commits intomasterfrom
fix-#1539
Aug 22, 2021
Merged

Don't start Sentry::SendEventJob's transaction#1547
st0012 merged 2 commits intomasterfrom
fix-#1539

Conversation

@st0012
Copy link
Copy Markdown
Contributor

@st0012 st0012 commented Aug 22, 2021

Fixes #1539

@st0012 st0012 added this to the 4.7.0 milestone Aug 22, 2021
@st0012 st0012 self-assigned this Aug 22, 2021
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 22, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.28%. Comparing base (3ddb146) to head (b4c3b05).
Report is 737 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1547      +/-   ##
==========================================
+ Coverage   97.89%   98.28%   +0.38%     
==========================================
  Files         222      127      -95     
  Lines       10838     7002    -3836     
==========================================
- Hits        10610     6882    -3728     
+ Misses        228      120     -108     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@st0012 st0012 changed the title Don't event start Sentry::SendEventJob's transaction Don't even start Sentry::SendEventJob's transaction Aug 22, 2021
@st0012 st0012 changed the title Don't even start Sentry::SendEventJob's transaction Don't start Sentry::SendEventJob's transaction Aug 22, 2021
@st0012 st0012 merged commit 2cc4c21 into master Aug 22, 2021
@st0012 st0012 deleted the fix-#1539 branch August 22, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sentry-rails: NoMethodError: undefined method `span' for nil:NilClass

2 participants