Support after-retry reporting to sentry-sidekiq#1532
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1532 +/- ##
==========================================
+ Coverage 98.21% 98.73% +0.52%
==========================================
Files 218 125 -93
Lines 10624 6879 -3745
==========================================
- Hits 10434 6792 -3642
+ Misses 190 87 -103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
When set to true, `sentry-sidekiq` only reports exceptions when the job has been fully retried.
|
|
||
| retry_option = context.dig(:job, "retry") | ||
|
|
||
| if Sentry.configuration.sidekiq.report_after_job_retries && retry_option.is_a?(Integer) |
There was a problem hiding this comment.
@st0012 it looks like retry_option is a boolean here; when would it be an integer?
Never mind, I realized the job itself has to be configured with sidekiq_options retry: SOME_INTEGER for this feature to work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
config.sidekiq.report_after_job_retriesoption (default:false).When activated,
sentry-sidekiqwill wait for a job's retries to be exhausted before reporting the exception. Worker without theretryoption will not be affected.Closes #781