Correctly pass arguments to a rake task#1514
Merged
st0012 merged 1 commit intogetsentry:masterfrom Jul 26, 2021
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1514 +/- ##
==========================================
+ Coverage 98.19% 98.75% +0.56%
==========================================
Files 218 123 -95
Lines 10597 6770 -3827
==========================================
- Hits 10406 6686 -3720
+ Misses 191 84 -107 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
st0012
reviewed
Jul 26, 2021
a23020e to
f945ffb
Compare
st0012
approved these changes
Jul 26, 2021
Contributor
st0012
left a comment
There was a problem hiding this comment.
thanks for catching this and the PR 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Due to effect of #1509, arguments of Rake task are lost now. This patch pass arguments to Rake as before.
I'm sorry to miss this!