Skip to content

Add isolated tests to sentry-rails#1497

Merged
st0012 merged 3 commits intomasterfrom
add-isolation-tests
Jul 4, 2021
Merged

Add isolated tests to sentry-rails#1497
st0012 merged 3 commits intomasterfrom
add-isolation-tests

Conversation

@st0012
Copy link
Copy Markdown
Contributor

@st0012 st0012 commented Jul 4, 2021

Some initialization logics are hard to test with the normal RSpec setup. Isolate each cases into their own files will make it easier (but also slower).

@st0012 st0012 added this to the 4.7.0 milestone Jul 4, 2021
@st0012 st0012 self-assigned this Jul 4, 2021
@st0012 st0012 changed the title Add isolation tests to sentry-rails Add isolated tests to sentry-rails Jul 4, 2021
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 4, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.77%. Comparing base (083a0d6) to head (bbec128).
⚠️ Report is 782 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1497      +/-   ##
==========================================
+ Coverage   98.21%   98.77%   +0.56%     
==========================================
  Files         218      123      -95     
  Lines       10553     6716    -3837     
==========================================
- Hits        10365     6634    -3731     
+ Misses        188       82     -106     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@st0012 st0012 merged commit 7b9f8fc into master Jul 4, 2021
@st0012 st0012 deleted the add-isolation-tests branch July 4, 2021 07:52
@st0012 st0012 modified the milestones: 4.7.0, 4.6.1 Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants