Add tracing support to sentry-delayed_job#1482
Merged
st0012 merged 1 commit intogetsentry:masterfrom Jun 25, 2021
Merged
Conversation
2a009b1 to
d0a1874
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1482 +/- ##
==========================================
+ Coverage 98.20% 98.76% +0.56%
==========================================
Files 218 123 -95
Lines 10467 6716 -3751
==========================================
- Hits 10279 6633 -3646
+ Misses 188 83 -105 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fsateler
commented
Jun 24, 2021
st0012
reviewed
Jun 25, 2021
st0012
reviewed
Jun 25, 2021
Contributor
st0012
left a comment
There was a problem hiding this comment.
hey thanks a lot for adding this 👍
just left some comments for polishing. I think you also need to rebase the branch and resolve the conflict in order to start the build.
7df7aaa to
dcfeb63
Compare
Contributor
Author
|
Done! |
st0012
approved these changes
Jun 25, 2021
Contributor
st0012
left a comment
There was a problem hiding this comment.
Thanks for implementing this 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1312