Allow toggling background sending on the fly#1447
Merged
Conversation
In some cases, being able to disable background sending globally is crucial for both users and the SDK itself. For example, Rails supports having different modes for running the application (server, console, runner, task...etc). In the runner or task mode, the process is killed right after script is returned, usually before the background worker have the chance to send the events. Here's an example issue: #1324 Although Rails provides callbacks for different modes, they're ran after the SDK initialization. And under the current setup, it's not possible to temporarily bypass background sending globally past the SDK initialization stage. So we can't disable the background workers in those callbacks. To solve the problem, this commit makes it possible to bypass background worker even after it's been initialized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1447 +/- ##
==========================================
+ Coverage 98.22% 98.83% +0.61%
==========================================
Files 213 118 -95
Lines 10034 6202 -3832
==========================================
- Hits 9856 6130 -3726
+ Misses 178 72 -106 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, being able to disable background sending globally is crucial for both users and the SDK itself.
For example, Rails supports having different modes for running the application (server, console, runner, task...etc). In the runner or task mode, the process is killed right after script is returned, usually before the background worker have the chance to send the events. Here's an example issue: #1324
Although Rails provides callbacks for different modes, they're ran after the SDK initialization. And under the current setup, it's not possible to temporarily bypass background sending globally past the SDK initialization stage. So we can't disable the background workers in those callbacks.
To solve the problem, this commit makes it possible to bypass background worker even after it's been initialized.