Skip to content

Fix NoMethodError when SDK's dsn is nil#1433

Merged
st0012 merged 2 commits intomasterfrom
fix-http-logger
May 6, 2021
Merged

Fix NoMethodError when SDK's dsn is nil#1433
st0012 merged 2 commits intomasterfrom
fix-http-logger

Conversation

@st0012
Copy link
Copy Markdown
Contributor

@st0012 st0012 commented May 6, 2021

Users may choose deactivating the SDK by simply not setting the dsn. But the current http_logger doesn't handle such case and would cause error.

@st0012
Fix NoMethodError when SDK's dsn is nil
0dec9e6 
Users may choose deactivating the SDK by simply not setting the dsn. But
the current http_logger doesn't handle such case and would cause error.
@st0012 st0012 self-assigned this May 6, 2021
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 6, 2021 •
edited
Loading

Codecov Report

Merging #1433 (0dec9e6) into master (6b20fbc) will increase coverage by 0.61%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1433      +/-   ##
==========================================
+ Coverage   98.22%   98.83%   +0.61%     
==========================================
  Files         213      118      -95     
  Lines       10018     6197    -3821     
==========================================
- Hits         9840     6125    -3715     
+ Misses        178       72     -106
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/net/http.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/net/http_spec.rb 100.00% <100.00%> (ø)
sentry-raven/spec/raven/utils/real_ip_spec.rb
sentry-raven/spec/raven/breadcrumbs_spec.rb
sentry-raven/spec/support/test_rails_app/app.rb
sentry-raven/lib/raven/interfaces/message.rb
sentry-raven/lib/raven/transports.rb
...-raven/spec/raven/integrations/rails/event_spec.rb
...try-raven/lib/raven/interfaces/single_exception.rb
sentry-raven/lib/raven/integrations/sidekiq.rb
... and 87 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b20fbc...0dec9e6. Read the comment docs.

@st0012 st0012 added this to the sentry-ruby-4.4.2 milestone May 6, 2021
@st0012 st0012 merged commit c9d542a into master May 6, 2021
@st0012 st0012 deleted the fix-http-logger branch May 6, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@st0012 st0012

Labels

sentry-ruby

Projects

None yet

Milestone

sentry-ruby-4.4.2

Development

Successfully merging this pull request may close these issues.

2 participants

@st0012 @codecov-commenter