Apply patches when initializing the SDK#1432
Merged
Conversation
This new change has 2 benefits: 1. It gives the SDK more control on how/when to apply the patches. 2. By applying patches later (usually in app initialization phase), we can avoid the conflict between different patching approaches. The 2 patching approaches are `alias` and `prepend`. When 2 gems patch the same class in this order, it'll cause "stack level too deep" error: ``` prepend <- sentry-ruby alias <- gems like scout_apm or rack-mini-profiler ``` After this commit, we can almost be certain that the order would be: ``` alias <- gems like scout_apm or rack-mini-profiler ---- prepend <- sentry-ruby ``` And thus avoid the error.
This was referenced May 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new change has 2 benefits:
The 2 patching approaches are
aliasandprepend. When 2 gems patch the same class in this order, it'll cause "stack level too deep" error:After this commit, we can almost be certain that the order would be:
And thus avoid the error.