Skip to content

set_initial_sample_decision should always respect the original decision#1423

Closed
st0012 wants to merge 2 commits intomasterfrom
fix-set-initial-sample-decision
Closed

set_initial_sample_decision should always respect the original decision#1423
st0012 wants to merge 2 commits intomasterfrom
fix-set-initial-sample-decision

Conversation

@st0012
Copy link
Copy Markdown
Contributor

@st0012 st0012 commented Apr 29, 2021

This is to address the issue found in this comment #1421 (comment)

@st0012 st0012 added this to the 4.4.0 milestone Apr 29, 2021
@st0012 st0012 self-assigned this Apr 29, 2021
@st0012 st0012 requested a review from rhcarvalho April 29, 2021 13:35
@st0012 st0012 mentioned this pull request Apr 29, 2021
Merged
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 29, 2021 •
edited
Loading

Codecov Report

Merging #1423 (090930d) into master (fa8f3ec) will increase coverage by 0.61%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1423      +/-   ##
==========================================
+ Coverage   98.21%   98.82%   +0.61%     
==========================================
  Files         213      118      -95     
  Lines        9982     6152    -3830     
==========================================
- Hits         9804     6080    -3724     
+ Misses        178       72     -106
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/transaction.rb 100.00% <ø> (ø)
sentry-ruby/spec/sentry/transaction_spec.rb 100.00% <100.00%> (ø)
...entry-raven/lib/raven/breadcrumbs/sentry_logger.rb
sentry-raven/lib/raven/base.rb
sentry-raven/spec/raven/logger_spec.rb
sentry-raven/lib/raven/core_ext/object/deep_dup.rb
sentry-raven/lib/raven/transports/stdout.rb
...ntry-raven/lib/raven/core_ext/object/duplicable.rb
sentry-raven/spec/raven/transports/stdout_spec.rb
...en/spec/raven/integrations/rails/activejob_spec.rb
... and 87 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa8f3ec...090930d. Read the comment docs.

@st0012 st0012 force-pushed the fix-set-initial-sample-decision branch from 090930d to 01165fe Compare April 29, 2021 13:41
@rhcarvalho
Copy link
Copy Markdown
Contributor

rhcarvalho commented Apr 29, 2021

See #1421 (comment)

Let's not change this right now.

@rhcarvalho rhcarvalho closed this Apr 29, 2021
@st0012 st0012 deleted the fix-set-initial-sample-decision branch June 21, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhcarvalho rhcarvalho Awaiting requested review from rhcarvalho

Assignees

@st0012 st0012

Labels

sentry-ruby Traces

Projects

None yet

Milestone

4.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@st0012 @codecov-commenter @rhcarvalho