Conversation
893f3a6 to
66d4d74
Compare
rhcarvalho
reviewed
Apr 16, 2021
9a2bf52 to
ecde56c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1402 +/- ##
==========================================
+ Coverage 98.19% 98.79% +0.59%
==========================================
Files 214 119 -95
Lines 9862 6045 -3817
==========================================
- Hits 9684 5972 -3712
+ Misses 178 73 -105
Continue to review full report at Codecov.
|
rhcarvalho
approved these changes
Apr 23, 2021
Contributor
rhcarvalho
left a comment
There was a problem hiding this comment.
Few suggestions, generally ltgm
- rate == 0 - Tracing enabled. Rejects all locally created transactions but respects sentry-trace. - 1 > rate > 0 - Tracing enabled. Samples locally created transactions with the rate and respects sentry-trace. - rate < 0 or rate > 1 - Tracine disabled.
6a7ad1d to
57c586c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rate == 0- Tracing enabled. Rejects all locally created transactions but respects sentry-trace.1 > rate > 0- Tracing enabled. Samples locally created transactions with the rate and respects sentry-trace.rate < 0orrate > 1- Tracine disabled.