Support config.debug configuration option#1400
Merged
Conversation
8fc97f1 to
4ba5b41
Compare
rhcarvalho
reviewed
Apr 22, 2021
Contributor
rhcarvalho
left a comment
There was a problem hiding this comment.
Maybe I'm misreading this, but it seems that regardless of debug = true/false we're always printing full event payloads to STDOUT?
st0012
commented
Apr 22, 2021
rhcarvalho
reviewed
Apr 22, 2021
Codecov Report
@@ Coverage Diff @@
## master #1400 +/- ##
==========================================
+ Coverage 98.20% 98.82% +0.62%
==========================================
Files 213 118 -95
Lines 9876 6068 -3808
==========================================
- Hits 9699 5997 -3702
+ Misses 177 71 -106
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the new
debugconfig option:As of now, SDK related errors are only logged with their error messages.
For example, assume we have this
before_sendcallback:The SDK only logs this
This is inconvenient for our users to debug their customization on the SDK. It also makes determining/reporting SDK issues harder (see #1383 (comment) for example).
So with when the new
config.debugoption set withtrue, it will log SDK errors with backtrace, just like we normally treat errors in our applications.Closes #1297