Conversation
bf5735f to
a7427aa
Compare
b01106c to
4368fda
Compare
Codecov Report
@@ Coverage Diff @@
## master #1354 +/- ##
==========================================
+ Coverage 98.08% 98.68% +0.59%
==========================================
Files 208 113 -95
Lines 9162 5327 -3835
==========================================
- Hits 8987 5257 -3730
+ Misses 175 70 -105
Continue to review full report at Codecov.
|
Member
|
Adding @rhcarvalho to double-check this. |
jan-auer
approved these changes
Mar 22, 2021
Member
jan-auer
left a comment
There was a problem hiding this comment.
Looks good to me, one minor suggestion below to clarify on the item type.
4368fda to
992520a
Compare
Normal events shouldn't have the `type` field. Only transactions should have `type: "transaction"`. But in the logs, we should still print normal events' type as `"event"`. For more information about the rules, please see https://github.com/getsentry/sentry-ruby/pull/1336/files#r596851969
992520a to
3cdf077
Compare
rhcarvalho
approved these changes
Mar 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on this discussion, normal events shouldn't have the
typeattribute and only transaction events should havetype: "transaction".So this PR:
type: "event"from normal eventsTransport's envelope generation logic: envelope's type is not equivalent to event's type