Conversation
st0012
commented
Mar 14, 2021
Codecov Report
@@ Coverage Diff @@
## master #1336 +/- ##
==========================================
+ Coverage 98.08% 98.71% +0.63%
==========================================
Files 208 114 -94
Lines 9173 5538 -3635
==========================================
- Hits 8997 5467 -3530
+ Misses 176 71 -105
Continue to review full report at Codecov.
|
jan-auer
requested changes
Mar 18, 2021
Member
jan-auer
left a comment
There was a problem hiding this comment.
Thank you! Please see the comments below. There is one request for change in the code checking for cached limits, and a few suggestions and clarifying questions.
sentry-ruby/spec/sentry/transport/http_transport_rate_limiting_spec.rb
Outdated
Show resolved
Hide resolved
jan-auer
approved these changes
Mar 29, 2021
If Sentry's 200 responses also contain rate limit related headers, we should store and update the SDK's rate limits like we see them in 429 responses. The only difference is that when receiving 429 responses the SDK should add default 60s delay to all event categories, which must not happen to 200 responses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sentry rate limits different types of events. And when rate limiting is enabled, it sends back a
429response to the SDK. Currently, the SDK would then raise an error like this:This change improves the SDK's handling on such responses by:
Closes #1072