Skip to content

Exceptions with nil message shouldn't cause issues#1327

Merged
st0012 merged 2 commits intomasterfrom
fix-#1323
Mar 11, 2021
Merged

Exceptions with nil message shouldn't cause issues#1327
st0012 merged 2 commits intomasterfrom
fix-#1323

Conversation

@st0012
Copy link
Copy Markdown
Contributor

@st0012 st0012 commented Mar 11, 2021

closes #1323

@st0012 st0012 added this to the 4.3.0 milestone Mar 11, 2021
@st0012 st0012 self-assigned this Mar 11, 2021
@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 11, 2021 •
edited
Loading

Codecov Report

Merging #1327 (c22932c) into master (7989855) will increase coverage by 0.62%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1327      +/-   ##
==========================================
+ Coverage   98.08%   98.70%   +0.62%     
==========================================
  Files         208      113      -95     
  Lines        9088     5260    -3828     
==========================================
- Hits         8914     5192    -3722     
+ Misses        174       68     -106
Impacted Files Coverage Δ
...try-ruby/lib/sentry/interfaces/single_exception.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/hub_spec.rb 100.00% <100.00%> (ø)
sentry-rails/lib/sentry/rails/active_job.rb 96.87% <0.00%> (-0.10%) ⬇️
...-sidekiq/spec/sentry/sidekiq/error_handler_spec.rb 100.00% <0.00%> (ø)
...ven/breadcrumbs/active_support_breadcrumbs_spec.rb
...ry-raven/spec/raven/interfaces/stack_trace_spec.rb
...ven/spec/raven/utils/exception_cause_chain_spec.rb
sentry-raven/spec/raven/configuration_spec.rb
sentry-raven/lib/raven/integrations/delayed_job.rb
...ations/rails/overrides/debug_exceptions_catcher.rb
... and 89 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7989855...c22932c. Read the comment docs.

@st0012 st0012 merged commit 0fdd3aa into master Mar 11, 2021
@st0012 st0012 deleted the fix-#1323 branch March 11, 2021 15:13
This was referenced Mar 12, 2021
Merged
Merged
Merged
Merged
Closed
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@st0012 st0012

Labels

sentry-ruby

Projects

None yet

Milestone

4.3.0

Development

Successfully merging this pull request may close these issues.

Exceptions with message set to nil cause Sentry.capture_error(e) to fail with NoMethodError: undefined method `byteslice' for nil:NilClass

2 participants

@st0012 @codecov-io