Skip to content

Refactor tracing implementation#1309

Merged
st0012 merged 5 commits intomasterfrom
refactor-tracing
Mar 4, 2021
Merged

Refactor tracing implementation#1309
st0012 merged 5 commits intomasterfrom
refactor-tracing

Conversation

@st0012
Copy link
Copy Markdown
Contributor

@st0012 st0012 commented Mar 3, 2021

  1. Fix a stupid typo on Transaction#set_initial_sample_decision
  2. Rename some of the methods/variables in CaptureExceptions middleware
  3. Make CaptureExceptions more customizable on starting transactions
  4. Make performance monitoring work with the multi-configuration setup

st0012 added 4 commits March 3, 2021 22:41
The original implementation always uses the active hub's configuration
when starting transactions. But since we allow users to work with
multiple hubs with different configurations, we should also allow them
to apply on the performance monitoring feature.
@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 3, 2021

Codecov Report

Merging #1309 (91d6ad2) into master (cb3c7b0) will increase coverage by 0.54%.
The diff coverage is 97.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1309      +/-   ##
==========================================
+ Coverage   97.99%   98.53%   +0.54%     
==========================================
  Files         205      110      -95     
  Lines        8822     4993    -3829     
==========================================
- Hits         8645     4920    -3725     
+ Misses        177       73     -104     
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/rack/capture_exceptions.rb 94.87% <91.66%> (+0.27%) ⬆️
...entry-rails/lib/sentry/rails/capture_exceptions.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/hub.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/transaction.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/transaction_spec.rb 100.00% <100.00%> (ø)
sentry-rails/app/jobs/sentry/send_event_job.rb 75.00% <0.00%> (-12.50%) ⬇️
...ven/lib/raven/breadcrumbs/active_support_logger.rb
...ntry-raven/lib/raven/processor/removestacktrace.rb
sentry-raven/lib/raven/integrations/sidekiq.rb
...ations/rails/overrides/debug_exceptions_catcher.rb
... and 91 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb3c7b0...91d6ad2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants