Skip to content

Add thread_id to Exception interface#1291

Merged
st0012 merged 1 commit intomasterfrom
add-thread-id-to-exception
Feb 17, 2021
Merged

Add thread_id to Exception interface#1291
st0012 merged 1 commit intomasterfrom
add-thread-id-to-exception

Conversation

@st0012
Copy link
Copy Markdown
Contributor

@st0012 st0012 commented Feb 17, 2021

The thread_id will help Sentry connect the exception's stacktrace with the threads interface we send. This can prevent some weird issues from happening.

Related issue: getsentry/sentry#23870

The thread_id will help Sentry connect the exception's stacktrace with
the threads interface we send. This can prevent some weird issues from
happening.
@st0012 st0012 added this to the sentry-ruby-4.2.2 milestone Feb 17, 2021
@st0012 st0012 self-assigned this Feb 17, 2021
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 17, 2021

Codecov Report

Merging #1291 (bb57c8d) into master (5b32ad4) will increase coverage by 0.47%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1291      +/-   ##
==========================================
+ Coverage   97.94%   98.41%   +0.47%     
==========================================
  Files         203      108      -95     
  Lines        8754     4920    -3834     
==========================================
- Hits         8574     4842    -3732     
+ Misses        180       78     -102     
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/event.rb 98.92% <100.00%> (+0.01%) ⬆️
...try-ruby/lib/sentry/interfaces/single_exception.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/client_spec.rb 96.79% <100.00%> (+0.02%) ⬆️
...ls/lib/sentry/rails/tracing/abstract_subscriber.rb 84.61% <0.00%> (-11.54%) ⬇️
sentry-rails/app/jobs/sentry/send_event_job.rb 75.00% <0.00%> (-6.25%) ⬇️
...ntry/rails/tracing/action_controller_subscriber.rb 93.75% <0.00%> (-6.25%) ⬇️
sentry-rails/lib/sentry/rails/active_job.rb 92.00% <0.00%> (-4.16%) ⬇️
...-sidekiq/spec/sentry/sidekiq/error_handler_spec.rb 100.00% <0.00%> (ø)
...try-raven/lib/sentry-raven-without-integrations.rb
sentry-raven/lib/raven/base.rb
... and 94 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b32ad4...bb57c8d. Read the comment docs.

@st0012 st0012 merged commit 70e8b8a into master Feb 17, 2021
@st0012 st0012 deleted the add-thread-id-to-exception branch February 17, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants