Skip to content

Don't detect project root for Rails apps#1243

Merged
st0012 merged 2 commits intomasterfrom
dont-detect-project-root-for-rails-apps
Jan 28, 2021
Merged

Don't detect project root for Rails apps#1243
st0012 merged 2 commits intomasterfrom
dont-detect-project-root-for-rails-apps

Conversation

@st0012
Copy link
Copy Markdown
Contributor

@st0012 st0012 commented Jan 28, 2021 

1. That's `sentry-rails`'s job
2. The current logic actually always fails when installed with
   `sentry-rails`. Because in the case the `Rails` in the code points to
   `Sentry::Rails` instead of the top-level `::Rails`.

@st0012
Don't detect project root for Rails apps
0763771 
1. That's `sentry-rails`'s job
2. The current logic actually always fails when installed with
   `sentry-rails`. Because in the case the `Rails` in the code points to
   `Sentry::Rails` instead of the top-level `::Rails`.
@st0012 st0012 self-assigned this Jan 28, 2021
@st0012 st0012 added this to the sentry-ruby-4.1.6 milestone Jan 28, 2021
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 28, 2021 •
edited
Loading

Codecov Report

Merging #1243 (a60892d) into master (3bce7c2) will increase coverage by 0.61%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1243      +/-   ##
==========================================
+ Coverage   97.92%   98.54%   +0.61%     
==========================================
  Files         193       98      -95     
  Lines        8291     4456    -3835     
==========================================
- Hits         8119     4391    -3728     
+ Misses        172       65     -107
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/configuration.rb 97.68% <100.00%> (+0.51%) ⬆️
sentry-raven/spec/raven/integrations/rack_spec.rb
...ations/rails/overrides/debug_exceptions_catcher.rb
sentry-raven/spec/raven/interface_spec.rb
...ven/lib/raven/breadcrumbs/active_support_logger.rb
...raven/spec/raven/processors/utf8conversion_spec.rb
...ntry-raven/spec/raven/utils/context_filter_spec.rb
sentry-raven/lib/raven/cli.rb
sentry-raven/spec/raven/utils/real_ip_spec.rb
sentry-raven/spec/raven/raven_spec.rb
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bce7c2...a60892d. Read the comment docs.

@st0012 st0012 force-pushed the dont-detect-project-root-for-rails-apps branch from d4f5276 to a60892d Compare January 28, 2021 07:49
@st0012 st0012 merged commit fe738bf into master Jan 28, 2021
@st0012 st0012 deleted the dont-detect-project-root-for-rails-apps branch January 28, 2021 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@st0012 st0012

Labels

sentry-ruby

Projects

None yet

Milestone

sentry-ruby-4.1.6

Development

Successfully merging this pull request may close these issues.

2 participants

@st0012 @codecov-io