Skip to content

Require the English library#1233

Merged
st0012 merged 1 commit intogetsentry:masterfrom
dentarg:patch-2
Jan 27, 2021
Merged

Require the English library#1233
st0012 merged 1 commit intogetsentry:masterfrom
dentarg:patch-2

Conversation

@dentarg
Copy link
Copy Markdown
Contributor

@dentarg dentarg commented Jan 25, 2021

https://ruby-doc.org/stdlib-2.7.1/libdoc/English/rdoc/English.html

Should get rid of this warning:

irb(main):001:0> Sentry.init {}
/Users/dentarg/.gem/ruby/2.7.1/gems/sentry-ruby-4.1.4/lib/sentry-ruby.rb:177: warning: global variable `$CHILD_STATUS' not initialized

@dentarg
Require the English library
1392327 
https://ruby-doc.org/stdlib-2.7.1/libdoc/English/rdoc/English.html

Should get rid of this warning:

```ruby
irb(main):001:0> Sentry.init {}
/Users/dentarg/.gem/ruby/2.7.1/gems/sentry-ruby-4.1.4/lib/sentry-ruby.rb:177: warning: global variable `$CHILD_STATUS' not initialized
```
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 25, 2021 •
edited
Loading

Codecov Report

Merging #1233 (1392327) into master (ff865eb) will increase coverage by 0.59%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1233      +/-   ##
==========================================
+ Coverage   97.92%   98.51%   +0.59%     
==========================================
  Files         193       98      -95     
  Lines        8280     4450    -3830     
==========================================
- Hits         8108     4384    -3724     
+ Misses        172       66     -106
Impacted Files Coverage Δ
sentry-ruby/lib/sentry-ruby.rb 98.78% <100.00%> (+0.01%) ⬆️
sentry-raven/spec/raven/linecache_spec.rb
sentry-raven/lib/raven/instance.rb
sentry-raven/spec/raven/transports/http_spec.rb
...ntry-raven/lib/raven/core_ext/object/duplicable.rb
sentry-raven/lib/raven/logger.rb
sentry-raven/lib/raven/interfaces/http.rb
...en/lib/raven/processor/removecircularreferences.rb
...raven/integrations/rails/controller_transaction.rb
sentry-raven/lib/raven/base.rb
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff865eb...1392327. Read the comment docs.

@st0012 st0012 added this to the sentry-ruby-4.1.5 milestone Jan 27, 2021
st0012
st0012 approved these changes Jan 27, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍

@st0012 st0012 merged commit f525a28 into getsentry:master Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@st0012 st0012 st0012 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

sentry-ruby

Projects

None yet

Milestone

sentry-ruby-4.1.5

Development

Successfully merging this pull request may close these issues.

3 participants

@dentarg @codecov-io @st0012