Merged
Conversation
It is a good practice to avoid global method definition. When method is defined in globally, this method can be called from outside of gem. Also, it may affect other gems that have the same named method.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1213 +/- ##
==========================================
+ Coverage 97.92% 98.52% +0.60%
==========================================
Files 193 98 -95
Lines 8238 4407 -3831
==========================================
- Hits 8067 4342 -3725
+ Misses 171 65 -106 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
st0012
approved these changes
Jan 17, 2021
Contributor
st0012
left a comment
There was a problem hiding this comment.
yeah I think your approach is much better, thanks for the suggestion 👍
Contributor
Author
|
Thanks for your quick review too! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is a good practice to avoid global method definition.
When method is defined in globally, this method can be called from outside of gem.
It may affect other gems that have the same named method.