Skip to content

Support capturing "sentry-trace" header from the middleware#1205

Merged
st0012 merged 2 commits intomasterfrom
fix-#1200
Jan 15, 2021
Merged

Support capturing "sentry-trace" header from the middleware#1205
st0012 merged 2 commits intomasterfrom
fix-#1200

Conversation

@st0012
Copy link
Copy Markdown
Contributor

@st0012 st0012 commented Jan 14, 2021

When sentry-trace is provided in the header, we should start the transaction with the information from the trace, including:

  1. trace_id
  2. parent_span_id
  3. sampled

Closes #1200

When `sentry-trace` is provided in the header, we should start the
transaction with the information from the trace, including:

1. trace_id
2. parent_span_id
3. sampled
@st0012 st0012 added this to the 4.1.4 milestone Jan 14, 2021
@st0012 st0012 self-assigned this Jan 14, 2021
@st0012 st0012 requested a review from HazAT January 14, 2021 11:50
@st0012 st0012 merged commit cf94ced into master Jan 15, 2021
@st0012 st0012 deleted the fix-#1200 branch January 15, 2021 07:33
@taylorthurlow
Copy link
Copy Markdown

taylorthurlow commented Jan 28, 2021

@st0012 Is this header something that's used internally and not intended to be part of the public API? Sending a request to a rack app with a sentry-trace HTTP header is accessible in the rack env with env["HTTP_SENTRY_TRACE"]. Am I misunderstanding the use case for this feature?

EDIT: I realize I should clarify a little - I'd expect rack to mess with the key name and change it to HTTP_SENTRY_TRACE, but this PR doesn't seem to account for that.

@st0012
Copy link
Copy Markdown
Contributor Author

st0012 commented Feb 1, 2021

@taylorthurlow ah yes you're right 🤦‍♂️ will address this asap!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pick up sentry-trace header on Rails/Rack

2 participants