Don't include headers & request info in tracing span or breadcrumb#1199
Merged
Don't include headers & request info in tracing span or breadcrumb#1199
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1199 +/- ##
==========================================
+ Coverage 97.99% 98.90% +0.91%
==========================================
Files 192 28 -164
Lines 8181 733 -7448
==========================================
- Hits 8017 725 -7292
+ Misses 164 8 -156 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Data like `request` or `headers` can be huge in some applications. They're also likely to contain complex data structure that's hard/impossible to serialize (some might cause infinite loop). Consider those information should have been collected in the `request` interface of the event, storing them in breadcrumbs could cause more harm than benefit.
|
This is not enough, you need to also remove |
st0012
added a commit
that referenced
this pull request
Jun 3, 2021
For the same reason mentioned in #1199
Contributor
Author
|
@leonid-shevtsov I'm sorry that I missed this comment 🙇 I've added #1463 to fix the issue. |
st0012
added a commit
that referenced
this pull request
Jun 3, 2021
For the same reason mentioned in #1199
st0012
added a commit
that referenced
this pull request
Jun 3, 2021
* Correct breadcrumb logger's test setup * Make sure span/breadcrumb doesn't contain response data For the same reason mentioned in #1199 * Extract data cleanup logic to a helper module * Update changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data like
requestorheaderscan be huge in some applications. They're also likely to contain complex data structure that's hard/impossible to serialize (some might cause infinite loop).Consider those information should have been collected in the
requestinterface of the event, storing them in breadcrumbs could cause more harm than benefit.