Skip to content

fix format headers for sentry-raven#1198

Merged
st0012 merged 1 commit intogetsentry:masterfrom
moofkit:fix-headers-serailization-raven
Jan 13, 2021
Merged

fix format headers for sentry-raven#1198
st0012 merged 1 commit intogetsentry:masterfrom
moofkit:fix-headers-serailization-raven

Conversation

@moofkit
Copy link
Copy Markdown
Contributor

@moofkit moofkit commented Jan 12, 2021

Description

Postpone headers serialization in sentry-raven
More details in PR: #1197

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 12, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.44%. Comparing base (703beed) to head (3c04e15).
⚠️ Report is 1206 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1198      +/-   ##
==========================================
- Coverage   97.99%   97.44%   -0.56%     
==========================================
  Files         192       95      -97     
  Lines        8181     3831    -4350     
==========================================
- Hits         8017     3733    -4284     
+ Misses        164       98      -66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@moofkit
Copy link
Copy Markdown
Contributor Author

moofkit commented Jan 12, 2021

it seems like because of changes does not cover the case https://github.com/getsentry/sentry-ruby/blob/master/sentry-raven/spec/raven/integrations/rack_spec.rb#L163 anymore.
Because from now it's trying to cast only values with http- prefix.

Should I change a spec that enforces this case with addin http- prefix?
Which seems to me something unlikely to put object in http header

Or we don't need this rescue code anymore?

@st0012
Copy link
Copy Markdown
Contributor

st0012 commented Jan 13, 2021

@moofkit don't worry about the test coverage drop. It's unlikely that we'll do any drastic change to the sentry-raven gem anyway 🙂

@st0012 st0012 assigned st0012 and unassigned st0012 Jan 13, 2021
@st0012 st0012 added this to the 3.1.2 milestone Jan 13, 2021
@st0012 st0012 merged commit 15b7f20 into getsentry:master Jan 13, 2021
@moofkit moofkit deleted the fix-headers-serailization-raven branch January 13, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants