Skip to content

Refactor RequestInterface#1187

Merged
st0012 merged 8 commits intomasterfrom
refactor-request-interface
Jan 8, 2021
Merged

Refactor RequestInterface#1187
st0012 merged 8 commits intomasterfrom
refactor-request-interface

Conversation

@st0012
Copy link
Copy Markdown
Contributor

@st0012 st0012 commented Jan 7, 2021

This PR:

  • Removed redundant rack/interface file.
  • Refactored RequestInterface's header processing.
  • Reorganized RequestInterface's specs and add a few more cases.
  • Renamed variable env_hash to just env

@st0012 st0012 added this to the 4.1.3 milestone Jan 7, 2021
@st0012 st0012 self-assigned this Jan 7, 2021
@st0012 st0012 force-pushed the refactor-request-interface branch from 75b0768 to 92f2e61 Compare January 7, 2021 09:19
@st0012 st0012 force-pushed the refactor-request-interface branch from 92f2e61 to 1b3b358 Compare January 7, 2021 09:24
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 7, 2021

Codecov Report

Merging #1187 (1b3b358) into master (611f1a2) will increase coverage by 0.58%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1187      +/-   ##
==========================================
+ Coverage   97.94%   98.53%   +0.58%     
==========================================
  Files         192       96      -96     
  Lines        8039     4230    -3809     
==========================================
- Hits         7874     4168    -3706     
+ Misses        165       62     -103     
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/rack.rb 100.00% <ø> (ø)
sentry-ruby/spec/sentry/event_spec.rb 100.00% <ø> (ø)
sentry-ruby/lib/sentry/event.rb 99.01% <100.00%> (+<0.01%) ⬆️
sentry-ruby/lib/sentry/interfaces/request.rb 98.07% <100.00%> (+0.70%) ⬆️
...y/spec/sentry/interfaces/request_interface_spec.rb 100.00% <100.00%> (ø)
sentry-raven/lib/raven/cli.rb
...ntry-raven/spec/raven/utils/context_filter_spec.rb
...en/lib/raven/integrations/sidekiq/error_handler.rb
sentry-raven/lib/raven/utils/real_ip.rb
sentry-raven/lib/raven/processor/post_data.rb
... and 90 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 611f1a2...1b3b358. Read the comment docs.

@st0012 st0012 force-pushed the refactor-request-interface branch from 1c82fd9 to b2e1c85 Compare January 7, 2021 10:11
@st0012 st0012 merged commit 6c0fe96 into master Jan 8, 2021
@st0012 st0012 deleted the refactor-request-interface branch January 8, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants