rm reference to old constant (from Rails v2.2)#1184
Merged
st0012 merged 1 commit intogetsentry:masterfrom Jan 6, 2021
Merged
Conversation
CGI::Session::CookieStore::TamperedWithCookie was originally referenced by Raven in a refactor of its backtrace cleaner in 2012. https://github.com/getsentry/sentry-ruby/pull/58/files#diff-2337b0e4ecfcd526e8dbf0aa6f3a5570a2228c2cc71afdf6ba0edd4d361a40c2R45 CGI::Session::CookieStore was removed from Rails in 2008 when ActionPack switched to using Rack-based sessions. rails/rails@ed70830#diff-018dc029403b3cf53f21aef6fc77debda6e09c0739f6d7ff6a1331e40e5135eaL48
st0012
approved these changes
Jan 6, 2021
Contributor
st0012
left a comment
There was a problem hiding this comment.
thanks for pointing this out. I can confirm that it's completely gone in Rails 5+ versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CGI::Session::CookieStore::TamperedWithCookie was defined as part of an extension of Ruby's CGI in Rails v2.2. So technically, it probably belongs in
sentry-railsas opposed tosentry-ruby. However, this constant is no longer present in Rails >= 5.0 (the requirement forsentry-rails).The
TamperedWithCookieconstant was originally referenced by Raven in a refactor of its backtrace cleaner in 2012. TheCookieStorewas removed from Rails in 2008 when ActionPack switched to using Rack-based sessions.Note: this constant is also referred to by
sentry-ravenbut I didn't bother removing it there since it's in maintenance mode.