Skip to content

Transaction improvements#1170

Merged
st0012 merged 5 commits intomasterfrom
minor-improvements
Dec 25, 2020
Merged

Transaction improvements#1170
st0012 merged 5 commits intomasterfrom
minor-improvements

Conversation

@st0012
Copy link
Copy Markdown
Contributor

@st0012 st0012 commented Dec 25, 2020

This PR does several minor improvements:

  1. Event sending message now distinguish event types, like: Sending transaction 37c3e74081a246dcbf636d919448f4be to Sentry.
  2. Rails' transaction names should match the action name, like PostsController#show, instead of the request path.
  3. Rails' transaction op should be rails.request instead of rack.request.

@st0012
Event sending log should distinguish event types
96a9c39
@st0012
Don't pop out transaction name after finishing controller actions
2bbded4 
It's unnecessary to pop the transaction out as the information won't
leak to elsewhere. And popping it actually makes the transaction events
lose the controller name.
@st0012 st0012 added this to the 4.1.2 milestone Dec 25, 2020
@st0012 st0012 self-assigned this Dec 25, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 25, 2020 •
edited
Loading

Codecov Report

Merging #1170 (ac1960e) into master (17ef766) will increase coverage by 0.51%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1170      +/-   ##
==========================================
+ Coverage   97.85%   98.37%   +0.51%     
==========================================
  Files         191       96      -95     
  Lines        7987     4185    -3802     
==========================================
- Hits         7816     4117    -3699     
+ Misses        171       68     -103
Impacted Files Coverage Δ
...entry-rails/lib/sentry/rails/capture_exceptions.rb 100.00% <100.00%> (ø)
...y-rails/lib/sentry/rails/controller_transaction.rb 100.00% <100.00%> (ø)
sentry-rails/spec/sentry/rails/tracing_spec.rb 98.33% <100.00%> (+0.71%) ⬆️
sentry-rails/spec/support/test_rails_app/app.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/rack/capture_exceptions.rb 93.93% <100.00%> (+0.39%) ⬆️
sentry-ruby/lib/sentry/transport.rb 97.91% <100.00%> (+0.04%) ⬆️
...integrations/rails/overrides/streaming_reporter.rb
sentry-raven/lib/raven/utils/real_ip.rb
...entry-raven/lib/raven/integrations/rack-timeout.rb
...b/raven/integrations/sidekiq/cleanup_middleware.rb
... and 91 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17ef766...ac1960e. Read the comment docs.

@st0012 st0012 force-pushed the minor-improvements branch from ac1960e to ab65e54 Compare December 25, 2020 08:53
@st0012 st0012 merged commit f94ec04 into master Dec 25, 2020
@st0012 st0012 deleted the minor-improvements branch December 25, 2020 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@st0012 st0012

Labels

sentry-rails

Projects

None yet

Milestone

4.1.2

Development

Successfully merging this pull request may close these issues.

3 participants

@st0012 @codecov-io @sl0thentr0py